Fixing resize split can cause crashes when node is root#4139
Open
Neko-Box-Coder wants to merge 1 commit into
Open
Fixing resize split can cause crashes when node is root#4139Neko-Box-Coder wants to merge 1 commit into
Neko-Box-Coder wants to merge 1 commit into
Conversation
JoeKar
reviewed
Jul 8, 2026
Neko-Box-Coder
force-pushed
the
FixResizeSplit
branch
from
84a6924 to
a2dac99
Compare
JoeKar
approved these changes
Jul 8, 2026
dmaluka
reviewed
Jul 12, 2026
| // String returns the string form of the node and all children (used for debugging) | ||
| func (n *Node) String() string { | ||
| if n == nil { | ||
| return "root" |
Collaborator
There was a problem hiding this comment.
What is this for? How is this related to the ResizeSplit fix?
A nil node is not a root node, is it? A root node it a non-nil node returned by NewRoot(), right?
Contributor
Author
There was a problem hiding this comment.
I guess it can return "nil"?
I think I was trying to print n.parent and it crashed, hence the check here.
Collaborator
There was a problem hiding this comment.
It is supposed to crash, no? Why need to print it?
Contributor
Author
There was a problem hiding this comment.
Yeah, true. I have removed it.
Fixing resize split can cause crashes when node is root. "Regression" of micro-editor#3983 where ResizeSplit() assumed that the root node always has a single child which aligns to the previous behavior
Neko-Box-Coder
force-pushed
the
FixResizeSplit
branch
from
a2dac99 to
86bca52
Compare
dmaluka
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing resize split can cause crashes when node is root.
"Regression" of #3983 where ResizeSplit() assumed that the root node always has a single child which aligns to the previous behavior.
Found this behavior when trying to resize a lone split like so:
where
tree_viewis a lone pane andResizePane()callsn.ResizeSplit(size).