uaiohttpclient: Use "utf8" encoding instead of "latin-1". - #1145
Open
dpgeorge wants to merge 2 commits into
Open
uaiohttpclient: Use "utf8" encoding instead of "latin-1".#1145dpgeorge wants to merge 2 commits into
dpgeorge wants to merge 2 commits into
Conversation
MicroPython now validates the encoding argument to encode/decode, and "latin-1" is not supported. So use "utf8" instead (which has the same behaviour as when MicroPython did not validate the encoding and silently passed it through using utf8). Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MicroPython now validates the encoding argument to encode/decode, and "latin-1" is not supported. So use "utf8" instead (which has the same behaviour as when MicroPython did not validate the encoding and silently passed it through using utf8).
Testing
Added a unittest which covers these changes and runs under CI. It failed prior to the fix here.
Generative AI
I did not use generative AI tools when creating this PR.