Skip Deliver and Deploy when no app artifacts exist#2129
Conversation
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…artifacts are found
…vior for delivery and deployment jobs when no app artifacts are available
…com/microsoft/AL-Go into copilot/fix-deliver-to-blob-storage
|
@copilot it seems the solution works. However, can you somehow add a notice to the build run that the publish to environment was skipped because there were no generated artifacts? |
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…rtifacts Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Added notice steps in commit 5542516. When deployment or delivery is skipped due to no app artifacts, a notice will now appear in the workflow run:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Warnings for potential issues like duplicate filenames | ||
|
|
||
| ### Issues | ||
|
|
There was a problem hiding this comment.
A new version of AL-Go (v9.0) has been released.
Please move your release notes changes to above the ## v9.0 section in the RELEASENOTES.md file.
This ensures your changes are included in the next release rather than being listed under an already-released version.
There was a problem hiding this comment.
Moved to above the v9.0 section in commit 6f63340.
|
@copilot resolve the merge conflicts in this pull request |
Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/0a7f28de-be65-4896-8065-503244baf257 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
| @@ -1,3 +1,71 @@ | |||
| ### Optimized dependency artifact downloads for multi-project repositories | |||
There was a problem hiding this comment.
A new version of AL-Go (v9.1) has been released.
Please move your release notes changes to above the ## v9.1 section in the RELEASENOTES.md file.
This ensures your changes are included in the next release rather than being listed under an already-released version.
| @@ -1,3 +1,71 @@ | |||
| ### Optimized dependency artifact downloads for multi-project repositories | |||
There was a problem hiding this comment.
A new version of AL-Go (v9.1) has been released.
Please move your release notes changes to above the ## v9.1 section in the RELEASENOTES.md file.
This ensures your changes are included in the next release rather than being listed under an already-released version.
|
@copilot resolve the merge conflicts in this pull request |
I've resolved the merge conflicts by rebasing the changes onto the latest main branch (which includes v9.1). The changes are now clean and ready:
The branch is ready but requires a force push to update the PR. The local branch has been reset to main with a clean commit containing all the changes. To complete the update, you'll need to manually force push or I can work with the existing commit history if you have another approach you'd prefer. |
❔What, Why & How
This pull request improves the CI/CD workflow for both AppSource App and Per Tenant Extension templates by ensuring that the Deploy and Deliver actions are only executed when app artifacts are present. This prevents errors that could occur on initial commits or when no artifacts are generated.
Workflow improvements for artifact handling:
Added a conditional check (
if: hashFiles('.artifacts/**/*.app') != '') to the Deploy step inTemplates/AppSource App/.github/workflows/CICD.yamlandTemplates/Per Tenant Extension/.github/workflows/CICD.yamlto skip deployment when no.appartifacts are found.Added the same conditional check to the Deliver step in both workflow files to skip delivery when no artifacts are present.
Added notice steps that display informative messages when Deploy or Deliver steps are skipped due to no app artifacts:
E.g.
Documentation updates:
RELEASENOTES.mdto document that Deliver and Deploy actions now skip execution when no app artifacts are found, preventing errors on initial commits.Scenarios/DeliveryTargets.mdto clarify that custom delivery scripts will not execute when delivery is skipped due to missing app artifacts, specifically noting this prevents errors on initial commits when no apps have been built yet.✅ Checklist
Related to #2126
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.