Skip settings schema validation on PowerShell versions less than 7 by Copilot · Pull Request #2231 · microsoft/AL-Go

Copilot · 2026-04-30T13:49:13Z

❔What, Why & How

On PS5.1, ValidateSettings shells out to pwsh.exe passing the full settings JSON as a command-line argument. For repositories with many projects/settings, the JSON can exceed the ~32K Windows command-line limit, producing:

Error validating settings. Error: Program 'pwsh.exe' failed to run: The filename or extension is too long

Fix: Silently skip schema validation entirely when $PSVersionTable.PSVersion.Major -lt 7. The ValidateSettings function now performs a hard return at the very beginning of its Process block on PS < 7, avoiding any JSON serialization or pwsh invocation. On PS7+, Test-Json is called directly (the previous Invoke-Command wrapper has been removed since it's no longer needed with the early exit guard).

✅ Checklist

Add tests (E2E, unit tests) — added Pester test verifying Test-Json is called on PS7+ and skipped on PS < 7, with no warnings produced
Update RELEASENOTES.md
Update documentation (e.g. for new settings or scenarios)
Add telemetry

Write settings JSON to a temp file instead of passing it as a command-line argument to pwsh.exe, which exceeds the Windows command-line length limit (~32K chars) for large settings. Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/90f81e6b-6fa6-4fa5-9a16-4c43637c704d Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

…th limit Instead of writing to a temp file, simply skip the validation when the settings JSON is too large (>30K chars) for the Windows command-line limit. Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/333f25d2-8e08-4ebf-8b95-fc6fe2001579 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/8ee7b1e9-d14b-41b8-b172-81c61ffe05c8 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot

Pull request overview

This PR addresses a Windows PowerShell 5.1 limitation where ValidateSettings shells out to pwsh and can exceed the Windows ~32K command-line length limit when passing large settings JSON, causing validation to fail.

Changes:

Add a PS5.1 guard to skip settings schema validation when the serialized settings JSON is larger than 30,000 characters.
Update release notes to document the fix for the “filename or extension is too long” validation error.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
RELEASENOTES.md	Documents the PS5.1 validation-length-limit fix in the Issues list.
Actions/.Modules/ReadSettings.psm1	Adds an early-exit condition in `ValidateSettings` for PS5.1 when settings JSON is very large.

mazhelez · 2026-04-30T15:01:51Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/2daf92be-f2f4-44c9-a10c-46a1bd01e4c9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot · 2026-04-30T15:04:54Z

@copilot apply changes based on the comments in this thread

Applied all three changes from the review in commit bb500e1:

Changed return → continue in the Process block so subsequent piped items still get validated.
Added an OutputWarning explaining that schema validation was skipped due to the PS5.1 command-line length limit.
Added a unit test in Tests/ReadSettings.Test.ps1 that verifies oversized JSON skips validation (with warning on PS5.1, or runs in-process without skipping on PS7+). All 12 ReadSettings tests pass.

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a56d8a43-8737-4e44-a8d7-e0b0370497b9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

…s test Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a6d20e17-ae77-432d-92ee-c96d102e2301 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

mazhelez · 2026-07-06T08:36:22Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-07-06T08:37:49Z

@copilot resolve the merge conflicts in this pull request

Resolved in the latest commit — merged main into the branch, keeping both the existing ValidateSettings test and the new doNotPerformUpgrade schema test added by main.

mazhelez · 2026-07-09T11:02:42Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-07-09T11:05:48Z

@copilot resolve the merge conflicts in this pull request

Resolved in the latest commit — merged main into the branch. The doNotPerformUpgrade test was removed since that setting was reverted from main; only the ValidateSettings skip test remains.

aholstrup1

Releasenote is off

Copilot AI and others added 3 commits April 30, 2026 13:31

Add release note for PS5.1 settings validation fix

e9b4c48

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/8ee7b1e9-d14b-41b8-b172-81c61ffe05c8 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot AI assigned Copilot and mazhelez Apr 30, 2026

Copilot created this pull request from a session on behalf of mazhelez April 30, 2026 13:49 View session

Copilot finished work on behalf of mazhelez April 30, 2026 13:50

Copilot AI requested a review from mazhelez April 30, 2026 13:50

mazhelez approved these changes Apr 30, 2026

View reviewed changes

mazhelez marked this pull request as ready for review April 30, 2026 13:51

mazhelez requested a review from a team as a code owner April 30, 2026 13:51

Copilot AI review requested due to automatic review settings April 30, 2026 13:51

Copilot started reviewing on behalf of mazhelez April 30, 2026 13:52 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Copilot started work on behalf of mazhelez April 30, 2026 15:02 View session

Address review: add warning on skip, use continue, add unit test

bb500e1

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/2daf92be-f2f4-44c9-a10c-46a1bd01e4c9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez April 30, 2026 15:05

Copilot AI requested a review from mazhelez April 30, 2026 15:05

mazhelez reviewed Apr 30, 2026

View reviewed changes

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Copilot started work on behalf of mazhelez April 30, 2026 20:12 View session

Remove warning when skipping schema validation on PS5.1

9bb017c

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a56d8a43-8737-4e44-a8d7-e0b0370497b9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez April 30, 2026 20:14

Copilot AI requested a review from mazhelez April 30, 2026 20:14

mazhelez reviewed Apr 30, 2026

View reviewed changes

Comment thread Tests/ReadSettings.Test.ps1 Outdated

Copilot started work on behalf of mazhelez April 30, 2026 20:18 View session

Remove unnecessary Should -Not -Throw assertions from ValidateSetting…

15e5296

…s test Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a6d20e17-ae77-432d-92ee-c96d102e2301 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez April 30, 2026 20:20

Copilot AI requested a review from mazhelez April 30, 2026 20:20

mazhelez requested a review from Copilot June 25, 2026 11:59

Copilot started reviewing on behalf of mazhelez June 25, 2026 12:00 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread Tests/ReadSettings.Test.ps1

aholstrup1 previously approved these changes Jul 2, 2026

View reviewed changes

Potential fix for pull request finding

f319eeb

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

mazhelez dismissed aholstrup1’s stale review via f319eeb July 6, 2026 08:32

Copilot started work on behalf of mazhelez July 6, 2026 08:36 View session

Resolve merge conflicts with main

5b8835b

Copilot finished work on behalf of mazhelez July 6, 2026 08:38

spetersenms previously approved these changes Jul 6, 2026

View reviewed changes

Copilot started work on behalf of mazhelez July 9, 2026 11:04 View session

Resolve merge conflicts with main

2a11100

Copilot AI dismissed spetersenms’s stale review via 2a11100 July 9, 2026 11:05

Copilot finished work on behalf of mazhelez July 9, 2026 11:06

mazhelez reviewed Jul 9, 2026

View reviewed changes

Comment thread RELEASENOTES.md Outdated

Copilot started work on behalf of mazhelez July 9, 2026 11:09 View session

Move PS5.1 fix release note above v9.1 into main section

bd0e7f0

Copilot finished work on behalf of mazhelez July 9, 2026 11:11

Copilot AI requested a review from mazhelez July 9, 2026 11:11

Copilot started work on behalf of mazhelez July 9, 2026 11:31 View session

Copilot finished work on behalf of mazhelez July 9, 2026 11:37

aholstrup1 reviewed Jul 9, 2026

View reviewed changes

Comment thread RELEASENOTES.md Outdated

Update RELEASENOTES.md

862a326

aholstrup1 approved these changes Jul 9, 2026

View reviewed changes

spetersenms approved these changes Jul 9, 2026

View reviewed changes

mazhelez merged commit ff14855 into main Jul 9, 2026
8 checks passed

Uh oh!

Conversation

Copilot AI commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❔What, Why & How

✅ Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mazhelez commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mazhelez commented Jul 6, 2026

Uh oh!

Copilot AI commented Jul 6, 2026

Uh oh!

mazhelez commented Jul 9, 2026

Uh oh!

Copilot AI commented Jul 9, 2026

Uh oh!

Uh oh!

aholstrup1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Apr 30, 2026 •

edited

Loading