Simplify BCApps e2e scenario to verify CI/CD and PR Build success#2306
Merged
Conversation
Copilot created this pull request from a session on behalf of
mazhelez
July 7, 2026 08:40
View session
Copilot
AI
changed the title
Limit BCApps E2E scenario to the projects in CICD.settings.json
Limit BCApps E2E scenario to CICD.settings.json projects and fix single-scenario filter failure
Jul 7, 2026
Copilot
AI
changed the title
Limit BCApps E2E scenario to CICD.settings.json projects and fix single-scenario filter failure
Fix E2E scenario filter crash and multi-pattern matching
Jul 7, 2026
Copilot
AI
changed the title
Limit BCApps E2E scenario to CICD.settings.json projects and fix single-scenario filter failure
Limit BCApps E2E scenario to CICD.settings.json projects, fix single-scenario filter, and quiet git init logging
Jul 8, 2026
Copilot
AI
changed the title
Limit BCApps E2E scenario to CICD.settings.json projects, fix single-scenario filter, and quiet git init logging
Simplify BCApps e2e scenario to verify CI/CD and PR Build success
Jul 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Simplifies the BCApps E2E scenario to focus on successful CI/CD and PR Build execution.
Changes:
- Limits BCApps builds to application projects and removes artifact-count assertions.
- Improves E2E scenario filtering.
- Suppresses repository initialization Git output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
e2eTests/scenarios/BCApps/runtest.ps1 |
Simplifies BCApps workflow validation. |
e2eTests/e2eTestHelper.psm1 |
Silences initialization Git commands. |
.github/workflows/E2E.yaml |
Corrects filtering and array handling. |
aholstrup1
approved these changes
Jul 10, 2026
spetersenms
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Rework the BCApps e2e scenario to limit the build to the
Apps *projects, reuse the push-triggered CI/CD run, and verify both CI/CD and PR builds conclude successfully with the expected artifacts — plus a couple of supporting e2e-infra fixes.e2eTests/scenarios/BCApps/runtest.ps1projectssettings change tomainalready triggers a full CI/CD build; the scenario reuses that push-triggered run (returned byAdd-PropertiesToJsonFile -commit -wait) instead of dispatching a second, redundantRunCICDrun.success—WaitWorkflowtoleratescancelled, so a cancelled run no longer passes.WaitWorkflow's global behavior is left unchanged.WaitWorkflownow callsRefreshTokenand rebuilds the headers from the refreshed$ENV:GH_TOKEN.WaitWorkflowcan outlive the 10-minute GitHub App token window, so the previous stale headers could 401 on a long-running build.Apps *projects definetestFolders(compiled into.buildartifacts/TestAppsand published as*-TestApps-*), soTest-ArtifactsFromRun+*-Apps-*/*-TestApps-*count assertions confirm the builds produced useful output..github/workflows/E2E.yaml$scenariosFilter | ForEach-Object { $scenario -like $_ }returned an array of booleans (always truthy) and did not filter. Now uses@(... | Where-Object { $scenario -like $_ }).Count -gt 0, with results wrapped in@()to guarantee arrays.e2eTests/e2eTestHelper.psm1-silentto the initialinvoke-git add/invoke-git commitinCreateAlGoRepositoryto suppress excessive git output during repo initialization.✅ Checklist