Skip to content

Simplify BCApps e2e scenario to verify CI/CD and PR Build success#2306

Merged
mazhelez merged 13 commits into
mainfrom
copilot/remove-bcapps-test-e2e-config
Jul 13, 2026
Merged

Simplify BCApps e2e scenario to verify CI/CD and PR Build success#2306
mazhelez merged 13 commits into
mainfrom
copilot/remove-bcapps-test-e2e-config

Conversation

Copilot AI commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

❔What, Why & How

Rework the BCApps e2e scenario to limit the build to the Apps * projects, reuse the push-triggered CI/CD run, and verify both CI/CD and PR builds conclude successfully with the expected artifacts — plus a couple of supporting e2e-infra fixes.

e2eTests/scenarios/BCApps/runtest.ps1

  • Pushing the projects settings change to main already triggers a full CI/CD build; the scenario reuses that push-triggered run (returned by Add-PropertiesToJsonFile -commit -wait) instead of dispatching a second, redundant RunCICD run.
  • Both the CI/CD and Pull Request Build runs are re-fetched after waiting and explicitly asserted to conclude with successWaitWorkflow tolerates cancelled, so a cancelled run no longer passes. WaitWorkflow's global behavior is left unchanged.
  • The re-fetch after WaitWorkflow now calls RefreshToken and rebuilds the headers from the refreshed $ENV:GH_TOKEN. WaitWorkflow can outlive the 10-minute GitHub App token window, so the previous stale headers could 401 on a long-running build.
  • Retained app/test-app artifact validation for both builds. The selected Apps * projects define testFolders (compiled into .buildartifacts/TestApps and published as *-TestApps-*), so Test-ArtifactsFromRun + *-Apps-*/*-TestApps-* count assertions confirm the builds produced useful output.

.github/workflows/E2E.yaml

  • Fixed scenario filtering: $scenariosFilter | ForEach-Object { $scenario -like $_ } returned an array of booleans (always truthy) and did not filter. Now uses @(... | Where-Object { $scenario -like $_ }).Count -gt 0, with results wrapped in @() to guarantee arrays.

e2eTests/e2eTestHelper.psm1

  • Pass -silent to the initial invoke-git add / invoke-git commit in CreateAlGoRepository to suppress excessive git output during repo initialization.

✅ Checklist

Copilot AI changed the title Limit BCApps E2E scenario to the projects in CICD.settings.json Limit BCApps E2E scenario to CICD.settings.json projects and fix single-scenario filter failure Jul 7, 2026
Copilot AI changed the title Limit BCApps E2E scenario to CICD.settings.json projects and fix single-scenario filter failure Fix E2E scenario filter crash and multi-pattern matching Jul 7, 2026
@mazhelez mazhelez changed the title Fix E2E scenario filter crash and multi-pattern matching Limit BCApps E2E scenario to CICD.settings.json projects and fix single-scenario filter failure Jul 7, 2026
Copilot AI changed the title Limit BCApps E2E scenario to CICD.settings.json projects and fix single-scenario filter failure Limit BCApps E2E scenario to CICD.settings.json projects, fix single-scenario filter, and quiet git init logging Jul 8, 2026
Copilot AI changed the title Limit BCApps E2E scenario to CICD.settings.json projects, fix single-scenario filter, and quiet git init logging Simplify BCApps e2e scenario to verify CI/CD and PR Build success Jul 9, 2026
@mazhelez mazhelez marked this pull request as ready for review July 10, 2026 09:18
@mazhelez mazhelez requested a review from a team as a code owner July 10, 2026 09:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simplifies the BCApps E2E scenario to focus on successful CI/CD and PR Build execution.

Changes:

  • Limits BCApps builds to application projects and removes artifact-count assertions.
  • Improves E2E scenario filtering.
  • Suppresses repository initialization Git output.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
e2eTests/scenarios/BCApps/runtest.ps1 Simplifies BCApps workflow validation.
e2eTests/e2eTestHelper.psm1 Silences initialization Git commands.
.github/workflows/E2E.yaml Corrects filtering and array handling.

Comment thread e2eTests/scenarios/BCApps/runtest.ps1 Outdated
Comment thread e2eTests/scenarios/BCApps/runtest.ps1 Outdated
Comment thread e2eTests/scenarios/BCApps/runtest.ps1

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread e2eTests/scenarios/BCApps/runtest.ps1
Comment thread e2eTests/scenarios/BCApps/runtest.ps1

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@mazhelez mazhelez enabled auto-merge (squash) July 10, 2026 14:39
@mazhelez mazhelez merged commit 16948d9 into main Jul 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants