Fix CI/CD pipeline failure for apps with unescaped double quotes in AppSource description#2312
Draft
spetersenms with Copilot wants to merge 4 commits into
Draft
Fix CI/CD pipeline failure for apps with unescaped double quotes in AppSource description#2312spetersenms with Copilot wants to merge 4 commits into
spetersenms with Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix CI/CD pipeline issue with quotation marks in app description
Fix CI/CD pipeline failure for apps with unescaped double quotes in AppSource description
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppSource apps that embed literal
"characters in their description field (e.g."hands-free"in the Circula Expenses Connector) causealtool.exe GetPackageManifestto emit invalid JSON. BcContainerHelper'sCompile-AppInNavContainer.ps1pipes this output directly toConvertFrom-Jsonwith no error handling, crashing the entire pipeline withConversion from JSON failed with error: After parsing a value an unexpected character was encountered.Changes
Actions/AL-Go-Helper.ps1— AddedPatchBcContainerHelperfunction, called fromDownloadAndImportBcContainerHelperimmediately before dot-sourcing. It patches the vulnerable line inCompile-AppInNavContainer.ps1to wrap thealtool GetPackageManifest | ConvertFrom-Jsoncall in atry/catch, falling back toGet-NavAppInfo(which reads app metadata without JSON deserialisation of the description). The patch is:try { ... }replacement so the original 20-space-indented$manifest =token cannot match on a second passTests/CompileFromWorkspace.Test.ps1— Added test case verifying the workspace compilation path already handlesConvertFrom-Jsonfailures from invalid app-manifest JSON gracefully (callsOutputWarningand continues).✅ Checklist