Skip to content

Fix CI/CD pipeline failure for apps with unescaped double quotes in AppSource description#2312

Draft
spetersenms with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-ci-cd-pipeline-issue
Draft

Fix CI/CD pipeline failure for apps with unescaped double quotes in AppSource description#2312
spetersenms with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-ci-cd-pipeline-issue

Conversation

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

AppSource apps that embed literal " characters in their description field (e.g. "hands-free" in the Circula Expenses Connector) cause altool.exe GetPackageManifest to emit invalid JSON. BcContainerHelper's Compile-AppInNavContainer.ps1 pipes this output directly to ConvertFrom-Json with no error handling, crashing the entire pipeline with Conversion from JSON failed with error: After parsing a value an unexpected character was encountered.

Changes

  • Actions/AL-Go-Helper.ps1 — Added PatchBcContainerHelper function, called from DownloadAndImportBcContainerHelper immediately before dot-sourcing. It patches the vulnerable line in Compile-AppInNavContainer.ps1 to wrap the altool GetPackageManifest | ConvertFrom-Json call in a try/catch, falling back to Get-NavAppInfo (which reads app metadata without JSON deserialisation of the description). The patch is:

    • Idempotent — uses a single-line try { ... } replacement so the original 20-space-indented $manifest = token cannot match on a second pass
    • Fail-safe — silently skips if the target pattern is absent (already patched or BcContainerHelper updated upstream)
  • Tests/CompileFromWorkspace.Test.ps1 — Added test case verifying the workspace compilation path already handles ConvertFrom-Json failures from invalid app-manifest JSON gracefully (calls OutputWarning and continues).

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry

Copilot AI changed the title [WIP] Fix CI/CD pipeline issue with quotation marks in app description Fix CI/CD pipeline failure for apps with unescaped double quotes in AppSource description Jul 9, 2026
Copilot AI requested a review from spetersenms July 9, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dependency on app with quotation marks in description break CI/CD pipeline

2 participants