Skip to content

Bug 629779: [Inventory] Show a single Export/Import item data action pair on Cost Adjustment and Item Card#9212

Open
alexei-dobriansky wants to merge 3 commits into
mainfrom
bugs/629779-UnifyCostAdjExportImportActions
Open

Bug 629779: [Inventory] Show a single Export/Import item data action pair on Cost Adjustment and Item Card#9212
alexei-dobriansky wants to merge 3 commits into
mainfrom
bugs/629779-UnifyCostAdjExportImportActions

Conversation

@alexei-dobriansky

@alexei-dobriansky alexei-dobriansky commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#629779

Summary

The Inventory Cost Adjustment page and the Item Card each showed two overlapping data export/import actions when the Manufacturing app was installed: a standard Export/Import Item Data pair plus a production pair (Export/Import Production Item Data / a second Export Item Data on the Item Card). This created ambiguity about which one to use.

Change

The system now detects at runtime whether Manufacturing is enabled (ApplicationAreaMgmtFacade.IsManufacturingEnabled()) and shows exactly one pair:

  • Manufacturing enabled -> the base pair is hidden (Visible = not ManufacturingEnabled) and the Manufacturing pair (ApplicationArea = Manufacturing) is shown, routing to the Mfg. Export Item Data XMLPort (production data).
  • Manufacturing not enabled -> the base pair is shown, routing to the Export Item Data XMLPort.

In both cases the actions are captioned "Export item data" / "Import item data" - no "Production"/"manufacturing" wording is visible to the user.

Files

  • CostAdjustmentOverview.Page.al - base pair re-captioned + gated on ManufacturingEnabled.
  • MfgCostAdjustmentOverview.PageExt.al - Mfg pair re-captioned, tooltips aligned, promoted refs added, fixed a stray Xmlport. line break.
  • ItemCard.Page.al - base Export item data action re-captioned + gated on ManufacturingEnabled.
  • MfgItemCard.PageExt.al - Mfg action re-captioned, tooltip aligned.
  • Propagated the Item Card change to the APAC/GB/IT/NA/RU BaseApp layers via miapp.

Notes

  • Pure UI caption/visibility change; no schema or public API change.

alexei-dobriansky and others added 3 commits July 8, 2026 11:00
… (629779)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@alexei-dobriansky alexei-dobriansky added the SCM GitHub request for SCM area label Jul 8, 2026
@alexei-dobriansky alexei-dobriansky self-assigned this Jul 8, 2026
@alexei-dobriansky alexei-dobriansky marked this pull request as ready for review July 8, 2026 09:05
@alexei-dobriansky alexei-dobriansky requested a review from a team July 8, 2026 09:05
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@alexei-dobriansky

Copy link
Copy Markdown
Contributor Author

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR hides the standard item data actions when Manufacturing is enabled and lets the Manufacturing page extensions provide the visible actions instead. When Manufacturing is not enabled, the standard actions remain visible.

The changed action registrations look consistent. Cost Adjustment keeps the base Export/Import actionrefs but hides the underlying base actions when Manufacturing is enabled, and the Manufacturing extension adds matching promoted actionrefs. Item Card hides the base export action in W1 and propagated country-layer pages, while the W1 Manufacturing extension provides the Manufacturing export action. I did not find an orphaned or double-registered action path in the changed files.

Suggestions

None.

Risk assessment and necessity

Risk: Low. The change is limited to page action captions and visibility on Item Card and Cost Adjustment Overview, plus matching Manufacturing page extension action refs. No schema, public API, or data-processing behavior changes.

Necessity: The change is needed because Manufacturing currently exposes overlapping standard and Manufacturing export/import actions. The PR keeps one visible action set per Manufacturing state and routes to the matching XMLPort.


[AI-PR-REVIEW] version=1 system=github pr=9212 round=1 by=alexei-dobriansky sha=790cb3d15f829427258a1c28fbe5d77c5a3e8de4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant