[main] GitHub event batch 1746

[AleksandricMarko]

Linked work

Fixes AB#638497
Fixes AB#638498
Fixes AB#638499
Fixes AB#638506
Fixes AB#638507
Fixes AB#639003
Fixes AB#639008
Fixes AB#640232

https://github.com/microsoft/ALAppExtensions/issues/30044
https://github.com/microsoft/ALAppExtensions/issues/30033
https://github.com/microsoft/ALAppExtensions/issues/30041
https://github.com/microsoft/ALAppExtensions/issues/30144
https://github.com/microsoft/ALAppExtensions/issues/30051
https://github.com/microsoft/ALAppExtensions/issues/30118
https://github.com/microsoft/ALAppExtensions/issues/30119
microsoft/ALAppExtensions#30259

[github-actions]

Copilot PR Review

Iteration 1 · Outcome: completed

All applicable sub-skills completed with no findings; al-upgrade-review and al-ui-review were not-applicable (no upgrade/migration objects or page/control-add-in files in the diff); al-privacy-review found no applicable knowledge for this diff.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

[alexei-dobriansky]

Agentic PR Review - Round 1

Recommendation: Request Changes

What this PR does

This PR batches eight extensibility requests across Item Journal posting, Copy Sales Document, planning worksheet calculation, Sales Price Calc. Mgt., and warehouse put-away creation. The event locations mostly preserve default behavior when no subscriber is present, and git diff --check is clean. However, several new public event names or parameter lists do not match the linked event requests, and one existing public event signature is changed in place.

Suggestions

S1 - Planning event omits requested record
The planning event only passes Item. AB#639003 requests OnAfterSetAtStartPositionOnPreDataItem(var Item; var MarkedItem). Add the requested MarkedItem parameter, or this event cannot support the requested scenario.

S2 - Codeunit 22 events use different contracts
OnBeforeSetRemainingQuantityAndFlags and OnApplyItemLedgEntryOnBeforeZeroRemainingQtyExit do not match the requested event names. Keep the current timing, but expose the requested public names and parameter contracts.

S3 - Sales and warehouse event names differ
The PR adds OnBeforeGetSourceDocumentBasedOnFromDocType and OnCreatePutAwayFromDiffSourceOnAfterSplitPerSourceType. The linked requests ask for OnBeforeOpenPage and OnAfterSplitPostedWhseRcptLine. Align the public event contracts or document why the request changed.

S4 - Existing pricing event changes signature
OnCalcBestUnitPriceOnBeforeCalcBestUnitPriceConvertPrice is an existing public event. Adding parameters can break subscribers. Add a compatible path, or obsolete the old contract before replacing it.

Risk assessment and necessity

Risk: These are public integration event contracts in sensitive BaseApp areas, including posting, planning, warehouse processing, and pricing. A wrong event name, missing parameter, or changed existing signature can make subscriber code fail to compile or leave the original extensibility gap unresolved.

Necessity: The linked event-request bugs describe real extensibility gaps. The changes are necessary only if the published contracts match the requested timing and signatures.

---

[AI-PR-REVIEW] version=1 system=github pr=9224 round=1 by=alexei-dobriansky sha=84129559a1827b20dd9757f57aad3f85422b6f59