Skip to content

Hide Provide feedback action on E-Document Purchase Draft when user-i…#9257

Open
Explorer986 wants to merge 1 commit into
mainfrom
kumarjatin/641590
Open

Hide Provide feedback action on E-Document Purchase Draft when user-i…#9257
Explorer986 wants to merge 1 commit into
mainfrom
kumarjatin/641590

Conversation

@Explorer986

@Explorer986 Explorer986 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What & why

Hides the Provide feedback action on E-Document Purchase Draft (page 6181) when a tenant
admin has disabled user feedback in PPAC. Previously the button showed and opened a dialog
that did nothing after confirm. Now OnOpenPage reads
Tenant Feedback Settings.GetUserInitiatedFeedbackEnabled() and gates the action's
Visible, with a defensive guard in ProvideFeedback().

Linked work

Fixes #

AB#635853

How I validated this

  • Read the full diff — only the intended 14-line change.
  • Built E-Document Core locally, no new warnings.
  • Ran in BC: feedback on → action visible; feedback off → hidden.
  • No test added — visibility depends on PPAC (platform DotNet), not mockable here.

Risk & compatibility

Low, UI-only. No schema/permission/upgrade impact. PPAC setting is platform-cached (~30 min)
and read at page open, so a toggle applies on next open.

…nitiated feedback is disabled in PPAC

Slice 641590 / AB#635853: read Tenant Feedback Settings.GetUserInitiatedFeedbackEnabled() at page open and gate the GetFeedback action visibility, with a defensive guard in ProvideFeedback().
@Explorer986 Explorer986 requested review from a team July 8, 2026 13:33
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 8, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant