Bug 637507: [master] [Report 743 VAT Reconciliation Report] Incorrect VAT Base and Amount when using Non-Deductible VAT

[AleksanderGladkov]

ISSUE:
The VAT Reconciliation Report always includes the Non-Deductible VAT in the reported base and VAT amounts, with no way to report the deductible portion only.

SOLUTION:
Added a "VAT Amount Type" option to the report letting the user choose between including Non-Deductible VAT or reporting deductible VAT only.

TESTS:
Added scenarios covering both options.

Fixes AB#637507

[github-actions]

Copilot PR Review

Iteration 1 · Outcome: completed

All applicable sub-skills completed; al-ui-review was not-applicable (no page/control-add-in files in diff); al-security-review and al-privacy-review found no applicable knowledge for this diff.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

[alexei-dobriansky]

Agentic PR Review - Round 1

Recommendation: Request Changes

What this PR does

This PR adds a request-page option to Report 743 so users can keep the current full VAT amounts or show only the deductible VAT part. The default enum value keeps the existing include-NDV behavior.

The arithmetic uses the right VAT Entry fields for the two built-in options, and the tests cover several purchase, journal, reverse charge, and sales paths. The remaining issue is that the report still calculates from each G/L Entry - VAT Entry Link. In NDV postings, one VAT Entry can be linked from more than one G/L Entry, so the same deductible amount can still be counted more than once in report totals.

Suggestions

S1 - Deduplicate VAT entries before summing
The report still loops by G/L Entry and adds VATEntry.Base / VATEntry.Amount for every G/L Entry - VAT Entry Link. In NDV postings, the same VAT Entry can be linked from more than one G/L Entry, so the report can still count the deductible amount more than once. Track processed VAT Entry numbers for the relevant report scope, or calculate from VAT Entry directly before producing the totals.

S2 - Assert totals for both amount types
The new tests filter the dataset to one GLAccountNo_GLEntry row and do not check report totals or extra rows. Add assertions for the summed Purchase VAT / Base Amount Purchase VAT with both Include Non-Deductible VAT and Deductible VAT Only, especially the 75% NDV purchase invoice and journal cases. Otherwise a duplicated row can still pass the tests.

S3 - Make the option enum closed
The new enum is Extensible = true, but the report only handles the two built-in values. An extension value will silently behave like Deductible VAT Only. Make the enum non-extensible, or add explicit handling for unknown values.

Risk assessment and necessity

Risk: This is a VAT report change, so wrong values can affect tax review and reconciliation. The change does not add or move event subscribers, so there is no publisher dependency to verify. The default option is backward compatible, but the report totals remain risky until duplicated VAT Entry links are handled.

Necessity: The linked Bug has a concrete repro for Non-Deductible VAT in Report 743, and the scenario is important enough to fix. Adding a deductible-only option is a reasonable small scope, but the fix must also prove that 75% NDV totals reconcile and that the old include-NDV option still behaves as intended.

---

[AI-PR-REVIEW] version=1 system=github pr=9260 round=1 by=alexei-dobriansky at=2026-07-08 lastSha=4f780151ae68250e98b9c065c92d70dad5f9a11c suggestions=S1,S2,S3

[ventselartur]

Do you miss the AI tag or you just did not use the AL test agent/skill?

[AleksanderGladkov]

I didn't use the skill I think.