Unwind the ark signature algorithm pinning#7954
Open
cjen1-msft wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the previously added pinning of the ARK certificate’s signature algorithm during SEV-SNP attestation verification, while still pinning the ARK public key and issuer (which are sufficient given the pinned key material hashing approach described in the PR context).
Changes:
- Removed the ARK signature-algorithm metadata from the pinned AMD root signing key definitions.
- Dropped the runtime check that compared the ARK certificate’s signature algorithm against pinned metadata, retaining the issuer check.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/pal/attestation.cpp |
Removes ARK signature-algorithm pinning logic and keeps issuer pinning during SNP report verification. |
include/ccf/pal/attestation_sev_snp.h |
Updates pinned ARK metadata to no longer include a signature-algorithm field. |
Comment on lines
56
to
57
| return name; | ||
| } |
achamayou
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7934 we pinned the algorithm for the ark public key. Except we actually pinned the signature algorithm for the ARK.
We already pin the key algorithm as we take the DER encoding of the public key: [bytes + algorithm] and sha256 that.
So this unwinds the extra constraint on the signature algorithm that was unnecessary.