Prevent experimental RDAT on released shader targets#8534
Open
tex3d wants to merge 8 commits into
Open
Conversation
Separating Add and Get to make sure only supported tables are explicitly added, and to prevent any use of unsupported tables by not adding tables on-demand later. Empty parts will always be culled for serialization.
experimental_rdat.hlsl - test conditions requiring experimental (release+1) support. experimental_rdat_rel_sm.hlsl - test conditions supported on released version.
Also require prerelease shader model or unbound validator for experimental RDAT data.
Logic for prerelease shader model and unbound validator version moved into MaxPartTypeForValVer, and Builder will return nullptr for GetTable on table that hasn't been added, so base AddShaderInfo on whether a key table in this experimental RDAT is present.
Add minimum validator version to RDAT_STRUCT_TABLE_DERIVED, allowing automatic record versioning (through stride).
V-FEXrt
approved these changes
Jun 17, 2026
V-FEXrt
left a comment
V-FEXrt
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable to me but I wouldn't say I'm very fimiliar with RDAT yet so a more experienced review here would be good
| #define RECORD_TYPE RuntimeDataFunctionInfo2 | ||
| RDAT_STRUCT_TABLE_DERIVED(RuntimeDataFunctionInfo2, RuntimeDataFunctionInfo, | ||
| FunctionTable) | ||
| FunctionTable, 1, 8) |
Collaborator
There was a problem hiding this comment.
These should use constants right? Otherwise they'll likely be forgetten when the values are updated
Collaborator
There was a problem hiding this comment.
IIUC those are already shipped values that can't change, so they are fine to be hard coded.
llvm-beanz
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will prevent experimental RDAT parts from being emitted when compiling to a released shader target, unless you explicitly supply -validator-version 0.0.
Fixes #8272