Cleanup builtin headers#8540
Open
llvm-beanz wants to merge 2 commits into
Open
Conversation
This change cleans up the built-in HLSL headers. The main changes are: enable_if: * Rename from enable_if.h to enable_if aligning with TC57 guidance * Add proper include guard * Add license block to header type_traits: * Created a type_traits header from trait definitions in linalg.h vector_utils: * Rename from vector_utils.h to vector_utils aligning with TC56 guidance * Remove restriction on SM 6.9 (this works with small vectors everywhere) * Add proper include guard * Add license block to header linalg.h * Split out type_traits * use enable_if and type_traits headers
V-FEXrt
approved these changes
Jun 16, 2026
Co-authored-by: Ashley Coleman <ascoleman@microsoft.com>
bob80905
approved these changes
Jun 16, 2026
bob80905
left a comment
bob80905
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Just for my curiosity, why doesn't the guidance apply to linalg.h -> linalg?
Collaborator
Author
linalg.h and the other dx and vk headers aren't part of the standard, they're platform-specific headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change cleans up the built-in HLSL headers. The main changes are:
enable_if:
type_traits:
vector_utils:
linalg.h