benchmark: add experimental diverse graph search integration#1222
Draft
narendatha wants to merge 3 commits into
Draft
benchmark: add experimental diverse graph search integration#1222narendatha wants to merge 3 commits into
narendatha wants to merge 3 commits into
Conversation
Adds a feature-gated (experimental_diversity_search) topk-diverse-search benchmark path: - DiverseKNN search wrapper in diskann-benchmark-core - FileAttributeProvider loading plaintext per-point attributes - TopkDiverseSearchPhase input, DiverseSearch plugin, and Knn impl wiring - Example config and sample attribute test data All additions are gated so default builds are unaffected.
Diverse graph search is now unconditionally compiled across the workspace. Removes the feature declaration from all six Cargo.toml files and ungates the associated modules, exports, types, tests, and benchmark plugin wiring.
Add SearchMode::DiverseAttribute with a type-erased ErasedAttributeProvider so attribute-bucket diverse search is dispatched through search_internal instead of a separate search_diverse method. Wire the disk benchmark to build the mode from JSON inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a feature-gated (experimental_diversity_search) topk-diverse-search benchmark path: