Fix BA2022 telemetry DLL binplacement on release/experimental#647
Draft
v-goradojcic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual port of WindowsAppSDK-Samples PR #609 for Bug 57941660.
Agg pipelines consume the release/experimental branch through SamplesBranch. The fix from PR #609 exists on main but is missing from release/experimental, so VS/MSBuild still binplaces sideloading telemetry DLLs into the AppLifecycle package layout under TelemetryDependencies.
This change adds AppxLogTelemetryFromSideloadingScript=false to Samples/Directory.Build.props on release/experimental to prevent those sideloading telemetry DLLs from being emitted.
Validation plan:
Run WinAppSDK-Aggregate-PR or Agg Nightly using the patched release/experimental branch.
Verify AppLifecycle TelemetryDependencies no longer contains:
Only after layout validation should BinSkim exclusion cleanup be evaluated separately.