Python: pass Ollama sample tools through options#6504
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Ollama chat client sample to pass tool configuration via an options dictionary rather than using a dedicated tools parameter.
Changes:
- Switched streaming call to
client.get_response(..., options={"tools": get_time}, stream=True) - Switched non-streaming call to
client.get_response(..., options={"tools": get_time})
| if stream: | ||
| print("Assistant: ", end="") | ||
| async for chunk in client.get_response(messages, tools=get_time, stream=True): | ||
| async for chunk in client.get_response(messages, options={"tools": get_time}, stream=True): |
| print("") | ||
| else: | ||
| response = await client.get_response(messages, tools=get_time) | ||
| response = await client.get_response(messages, options={"tools": get_time}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
options={"tools": ...}instead of the unsupportedtools=keywordFixes #6411.
Test plan
python -m py_compile python/samples/02-agents/providers/ollama/ollama_chat_client.pyrg -n "get_response\([^\n]*tools=" python/samples/02-agents/providers/ollama/ollama_chat_client.py python/packages -Stools=get_response calls and both sample calls passoptionsgit diff --check upstream/main..HEAD