perf: reduce allocations in data-driven test execution hot path by @Evangelink in #9617 (backport to rel/4.3)#9619
Open
nohwnd-bot wants to merge 1 commit into
Open
Conversation
Combines four micro-optimizations in the MSTest adapter execution path: - CloneForDataDrivenIteration: pass _properties directly to the ctor instead of building an intermediate snapshot Dictionary. The null/null ctor branch already takes a shallow copy, so one Dictionary + O(n) copy per data-driven iteration is removed. (microsoft#9602) - ExecuteTestAsync: add a fast path when no ExecutionContext was captured by [AssemblyInitialize]/[ClassInitialize] (the common case). Skips the TaskCompletionSource + closure + Action delegate allocations and awaits the executor directly; the captured-context slow path is unchanged. (microsoft#9603) - ReflectionTestMethodInfo.GetParameters(): cache the ParameterInfo[] since MethodInfo.GetParameters() allocates a fresh array on every call and the wrapped MethodInfo is immutable. (microsoft#9605, microsoft#9593) - TestMethodInfo.ResolveArguments(): use the cached ParameterTypes property instead of calling MethodInfo.GetParameters() directly. (microsoft#9605) - TestMethodRunner: reuse a single ReflectionTestMethodInfo wrapper across all data rows instead of allocating one per row. (microsoft#9605, microsoft#9593) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9617 to rel/4.3
/cc @Evangelink