Add getConstraint() and getDefault() getters to TypeParameter#4556
Draft
andrewbranch with Copilot wants to merge 2 commits into
Draft
Add getConstraint() and getDefault() getters to TypeParameter#4556andrewbranch with Copilot wants to merge 2 commits into
andrewbranch with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add .getConstraint() and .getDefault() getter to TypeParameter
Add getConstraint() and getDefault() getters to TypeParameter
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TypeParameterAPI object exposed no direct way to read a type parameter's constraint or default. Reading a constraint requiredChecker.getConstraintOfTypeParameter(type), and no getter existed for the default at all — inconsistent withSubstitutionType, which already hasgetConstraint().Changes
async/types.ts): addgetConstraint()andgetDefault()toTypeParameter, both returningType | undefined.async/api.ts):TypeObject.getConstraint()dispatches onTypeFlags.TypeParameter— type parameters resolve through the checker endpointgetConstraintOfTypeParameter, while substitution types keep the existing preloaded-handle path.getDefault()calls the newgetDefaultFromTypeParameterendpoint.fetchCheckerTyperegistry helper for checker-level endpoints keyed bytypethat resolve to a single optional type (mirrorsfetchBaseTypes).internal/api): registergetDefaultFromTypeParameterinproto.goand addhandleGetDefaultFromTypeParameterinsession.go, delegating to the already-exportedchecker.GetDefaultFromTypeParameterand returning null when absent.undefined).Notes for review
getConstraint()is kept as a single method that branches on type flags rather than duplicated, preservingSubstitutionType's preloaded-handle behavior while giving type parameters checker-backed resolution.