Get incremental mode closer to Strada#4557
Draft
jakebailey wants to merge 3 commits into
Draft
Conversation
Store declaration-shape signatures in noEmit incremental buildinfo so a subsequent comment-only edit in a widely imported module does not invalidate the importer cone as an API-shape change. On the standalone repro, the 400-spoke isolatedModules:false incremental Check time drops from about 0.047s to 0.001s; the 4000-spoke scaled case drops from 0.508s to 0.002s.
Only precompute declaration-shape signatures for noEmit incremental builds when isolatedModules is disabled and the file can affect multiple dependents or global scope. This keeps clean buildinfo closer to tsc for leaf files and isolatedModules projects while preserving the hub-fanout improvement. The 400-spoke repro keeps isolatedModules:false incremental Check time around 0.001s, and isolatedModules:true clean buildinfo stays compact.
Track old signatures while affected-file processing updates shape signatures, and serialize those old signatures while buildinfo reflects an in-progress state. This mirrors Strada's oldSignatures behavior instead of eagerly precomputing noEmit signatures. Also account forced declaration-signature emits as emit work in extended diagnostics, matching where Strada reports the same work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was copilot produced from an internal repro. massive baseline change, but: