chore(dockerfile): filtrer le lint hadolint par paths [FTTECH-10638]#154
Open
florentsorel wants to merge 1 commit into
Open
chore(dockerfile): filtrer le lint hadolint par paths [FTTECH-10638]#154florentsorel wants to merge 1 commit into
florentsorel wants to merge 1 commit into
Conversation
Ajoute un filtre `paths` (**/Dockerfile* + le workflow lui-même) sur les triggers `pull_request` et `push` du workflow Dockerfile distribué. Le job hadolint ne se déclenche plus sur les PR/push qui ne touchent aucun Dockerfile (bruit observé sur des PR docs-only). `merge_group` reste non filtré : les required checks en merge queue continuent de tourner, pas de PR bloquée. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Ce PR met à jour le workflow d’exemple Dockerfile (hadolint) afin d’éviter des exécutions inutiles sur des PR/push ne modifiant aucun Dockerfile, tout en conservant l’exécution en merge queue (merge_group) pour les required checks.
Changes:
- Ajout d’un filtre
pathssur le triggerpull_requestpour ne lancer hadolint que si unDockerfile*(ou le workflow) change. - Ajout d’un filtre
pathssur le triggerpush(branchesmasteretprod) avec la même logique.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicolasotmani
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does It Do?
Ajoute un filtre
pathssur les triggerspull_requestetpushdu workflow Dockerfile (lint hadolint) distribué danssample/workflows/dockerfile.yml:Le job hadolint ne se déclenche plus sur les PR/push qui ne modifient aucun Dockerfile.
Context
Le snippet était déclenché sur tous les
pull_request/push, donc le lint tournait à vide sur des PR sans rapport (constaté sur une PR docs-only de PanoramAI : panoramai#1515).matchFiles: "**/Dockerfile*"côté policy ne gère que l'installation du workflow, pas son déclenchement — le filtrepathsdoit vivre dans le snippet.Le trigger
merge_groupreste non filtré : les required checks évalués en merge queue continuent de tourner (un required check filtré parpathsresterait pending et bloquerait le merge). Même pattern quesample/workflows/mobsuccess.yml.Propagation : une fois mergé, le bot policy re-synchronise le bloc
DO NOT EDITdedockerfile.ymldans chaque repo.Test Plan
Dockerfile(à n'importe quel niveau) déclenche bien le lintCloses FTTECH-10638