Skip to content

Fix binary issue file handling #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix binary issue file handling #3514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bot/code_review_bot/revisions/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ def get_file_content(
try:
with (local_cache_repository / file_path).open() as f:
file_content = f.read()
except (FileNotFoundError, IsADirectoryError):
logger.warning("Failed to find issue's related file", path=file_path)
except (FileNotFoundError, IsADirectoryError, UnicodeDecodeError):
logger.warning("Failed to read issue's related file", path=file_path)
file_content = None
else:
try:
Expand Down
7 changes: 7 additions & 0 deletions bot/tests/test_revisions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ def test_autoland(mock_config, mock_revision_autoland):
)


def test_binary_file_content_is_ignored(mock_revision, tmp_path):
binary_file = tmp_path / "artifact.webp"
binary_file.write_bytes(b"RIFF\xac=\x00\x00WEBP")

assert mock_revision.get_file_content(binary_file.name, tmp_path) is None


def test_clang_files(mock_revision):
"""
Test clang files detection
Expand Down