Bump base image to Node 22 and reduce image size#83
Open
nvdk wants to merge 2 commits into
Open
Conversation
added 2 commits
June 17, 2026 15:15
This also switches to bookworm-slim for 3x smaller image. replaced `ps -p` check with equivalent `kill -0` check (ps is not available in slim image)
Member
Author
|
Note: I think we should also bump typescript to 5.x but I kept it out of this PR for simplicity |
Member
|
We definitely need to test the integration with the Node inspector, as that's why we switched from |
Member
Author
Yes I was aware :). This is why I kept bookworm, but switched to bookworm-slim. In my testing the node inspector now works correctly, but extra testing is always welcome 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the base image from node:20-bookworm to node:22-bookworm-slim, reducing the image size from ~452 MB to ~168 MB (~3× smaller).
Tested:
Notes:
ps -pcheck with equivalentkill -0check (ps is not available in slim image)