Revert double x86_64 builds - #107
Open
pbatard wants to merge 1 commit into
Open
Conversation
As explained in ncroxon#105, we don't really want to have to carry two versions of the x86_64 arch depending on whether a flag is being used or not. Instead we want to have a main x86_64 build that uses the default flags, with these defaults evolving, as needed, through major and minor version bumps. Therefore, this patch reverts the following commits: - ed3ffa3 - 9bb1ba0 - 1111825 - e5810c2 We also remove the separate lib/.gitignore as the main .gitignore is more than enough to filter any content we want to filter out and it makes it much easier to both let users of gnu-efi what is actually being filtered, as well as maintain ignored files.
Merged
Owner
|
I don't see any build failures...(which is good).. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #105, we don't really want to have to carry two versions of the x86_64 arch depending on whether a flag is being used or not. Instead we want to have a main x86_64 build that uses the default flags, with these defaults evolving, as needed, through major and minor version bumps.
Therefore, this patch reverts the following commits:
We also remove the separate lib/.gitignore as the main .gitignore is more than enough to filter any content we want to filter out and it makes it much easier to both let users of gnu-efi what is actually being filtered, as well as maintain ignored files.