Skip to content

Fix legacy user context menu loading#632

Open
AboMeezO wants to merge 1 commit into
neplextech:mainfrom
AboMeezO:fix/legacy-user-context-menu
Open

Fix legacy user context menu loading#632
AboMeezO wants to merge 1 commit into
neplextech:mainfrom
AboMeezO:fix/legacy-user-context-menu

Conversation

@AboMeezO

@AboMeezO AboMeezO commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Fixes legacy user context menu commands in @commandkit/legacy.

The loader already marks ApplicationCommandType.User commands as userContextMenu, but the plugin wrapper was checking command.messageContextMenu before wiring the user handler. As a result, user context menu commands could load/register without a runnable handler.

Changes:

  • Wire legacy user context menu handlers from command.userContextMenu.
  • Add regression coverage for legacy message/user context menu loading, registration data, and user handler execution.
  • Add a small test setup for the legacy package and keep test files out of build output.

Checked with:

  • pnpm --filter @commandkit/legacy test
  • pnpm --filter @commandkit/legacy check-types
  • pnpm --filter @commandkit/legacy build
  • pnpm test src/app/register/CommandRegistrar.context-menu.test.ts src/app/handlers/AppCommandHandler.hierarchical.test.ts from packages/commandkit

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

@AboMeezO is attempting to deploy a commit to the Neplex Team on Vercel.

A member of the Team first needs to authorize it.

@AboMeezO AboMeezO marked this pull request as ready for review June 8, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant