Adding initial LIBRENMS mappings for netutils#732
Conversation
| @@ -1,4 +1,5 @@ | |||
| """Dictionary object to store OUI information.""" | |||
|
|
|||
There was a problem hiding this comment.
Should not be needed, and will likely get reverted.
There was a problem hiding this comment.
The changes to this file are coming from ruff rules. I was just following ruff --fix after I realized there was an issue called out by ruff.
|
Can you link source of this information for ease of future findings? |
I'm not sure the best way to go about doing this since there really isn't a great summarized source, suggestions welcomed. In the current state this is all coming about as follows:
We could go through and try to add a mapping entry for each of the os/manufacturer entries, but there really isn't any great source of info for future findings/requirements. |
|
Think you'll need to add a bit to the development_script to to make sure proper doc tables are auto generated since this is a new mapping. netutils/development_scripts.py Line 37 in b3e13d2 |
9869d30 to
f9b292b
Compare
This is done. I had ran the script but forgot to update it first 😬 |
| # LibreNMS | Normalized | ||
| LIBRENMS_LIB_MAPPER_REVERSE = { | ||
| "arista_eos": "arista_eos", | ||
| "iosxe": "cisco_xe", | ||
| "iosxr": "cisco_xr", | ||
| "nxos": "cisco_nxos", | ||
| "junos": "juniper_junos", | ||
| "procera": "applogic_procera", | ||
| } |
There was a problem hiding this comment.
| # LibreNMS | Normalized | |
| LIBRENMS_LIB_MAPPER_REVERSE = { | |
| "arista_eos": "arista_eos", | |
| "iosxe": "cisco_xe", | |
| "iosxr": "cisco_xr", | |
| "nxos": "cisco_nxos", | |
| "junos": "juniper_junos", | |
| "procera": "applogic_procera", | |
| } | |
| # Normalized | LibreNMS | |
| LIBRENMS_LIB_MAPPER_REVERSE = { | |
| "arista_eos": "arista_eos", | |
| "cisco_xe": "iosxe", | |
| "cisco_nxos": "nxos", | |
| "cisco_xr": "iosxr", | |
| "juniper_junos": "junos", | |
| "applogic_procera": "procera", | |
| } |
These are in reverse of what they should be, e.g. juniper_junos is normalized.
There was a problem hiding this comment.
The below needs to be flipped as well
| "cisco_nxos": "nxos", | ||
| "cisco_xr": "iosxr", | ||
| "juniper_junos": "junos", | ||
| "applogic_procera": "procera", |
There was a problem hiding this comment.
Would this have ssh and be in netmiko? If so, let's try and reserve the name there, if not we need to add it to _MAIN_LIB_MAPPER
a275d73 to
7db22a5
Compare
Updating for comments and conflicts.
33070bb to
f5f32e7
Compare
Adding a mapping for LibreNMS values to network_driver values for the initial values in use.