Skip to content

fix(auto-upload): skip check - #17401

Open
alperozturk96 wants to merge 1 commit into
masterfrom
fix/auto-upload-skip-check
Open

fix(auto-upload): skip check#17401
alperozturk96 wants to merge 1 commit into
masterfrom
fix/auto-upload-skip-check

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

Issue

Worker might mark entity as handled but this is not enough worker may get killed and never reached to the actual upload thus oc upload records should be checked as well.

Fixes

#15573

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6464
Dodgy code206206
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4040
Security1919
Total389389

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/30632262721/artifacts/8794164956
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

@DricomDragon

Copy link
Copy Markdown

I installed the QA app, logged in, gave permission to manage all files, (disabled auto-upload on stock APK), configured the auto upload of video and photograph in camera (after having renamed the previous folder to Camera1 to prevent mass upload), Wi-Fi is enabled, I plugged my phone, took a photograph and video : no effect.

Unplug from charger, plug to my computer, capture logs, go to uploads, pause / play, go to manage auto uploads : I can see my picture and video in the auto-upload configurator, but nothing automatically uploaded yet. Maybe unrelated to your patch, though.

Here are the logs :
qa-logs-redacted.txt

I will use this QA version from now on, I will notice you about uploads or skips when noticed.

Thanks for your amazing work, have a good day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AutoUpload files skipped or upload not starting

2 participants