fix: show error when Nextcloud or OpenProject is unreachable in bashscript#1083
Open
nabim777 wants to merge 1 commit into
Open
fix: show error when Nextcloud or OpenProject is unreachable in bashscript#1083nabim777 wants to merge 1 commit into
nabim777 wants to merge 1 commit into
Conversation
nabim777
force-pushed
the
fix-sh/show-error-message
branch
3 times, most recently
from
0bc1c04 to
a519dbe
Compare
nabim777
changed the title
nabim777
requested review from
Ashim-Stha,
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
psatyal,
saw-jan and
wielinde
as code owners
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
fix-sh/show-error-message
branch
from
a519dbe to
753254c
Compare
saw-jan
reviewed
Jun 29, 2026
Comment on lines
-46
to
-52
| if [[ $INTEGRATION_SETUP_TEMP_DIR == "" ]]; then | ||
| log_info "Using default temp dir: ${INTEGRATION_SETUP_DEFAULT_TEMP_DIR}" | ||
| INTEGRATION_SETUP_TEMP_DIR=${INTEGRATION_SETUP_DEFAULT_TEMP_DIR} | ||
| mkdir -p ${INTEGRATION_SETUP_TEMP_DIR} | ||
| else | ||
| log_info "Using ${INTEGRATION_SETUP_TEMP_DIR} as non-default temporary directory" | ||
| if [ ! -d "${INTEGRATION_SETUP_DEFAULT_TEMP_DIR}" ]; then |
Collaborator
There was a problem hiding this comment.
this looks fine here. why move down?
Collaborator
Author
There was a problem hiding this comment.
It was providing the log message before the error messages.
I moved it down, as it is closer to where the script actually starts creating temporary files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change improves in bash script for error handling when checking the Nextcloud or openproject instance status. If the nextcloud or openproject instance is unreachable or returns an error, the script now logs a error message.
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile