Skip to content

ansible: update cargo/rustc on Ubuntu 24.04#4393

Merged
richardlau merged 1 commit into
nodejs:mainfrom
richardlau:rust
Jul 3, 2026
Merged

ansible: update cargo/rustc on Ubuntu 24.04#4393
richardlau merged 1 commit into
nodejs:mainfrom
richardlau:rust

Conversation

@richardlau

@richardlau richardlau commented Jul 3, 2026

Copy link
Copy Markdown
Member

Refs: #4265


Deployment

  • test-azure-ubuntu2404_docker-arm64-1
  • test-azure-ubuntu2404_docker-arm64-2
  • test-azure-ubuntu2404_docker-arm64-3
  • test-digitalocean-ubuntu2204_docker-x64-1
  • test-digitalocean-ubuntu2204_docker-x64-2
  • test-digitalocean-ubuntu2404-x64-1
  • test-hetzner-ubuntu2404-x64-1
  • test-hetzner-ubuntu2404-x64-2
  • test-ibm-ubuntu2204_docker-x64-1
  • test-ibm-ubuntu2404-x64-1
  • test-osuosl-ubuntu2404_docker-arm64-1
  • test-rackspace-ubuntu2404-x64-1
  • test-rackspace-ubuntu2404-x64-2

Signed-off-by: Richard Lau <richard.lau@ibm.com>
Comment on lines 22 to +25
cargo-1.82 \
rustc-1.82 \
cargo-1.89 \
rustc-1.89 \

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both Dockerfiles we only really need cargo-1.89/rustc-1.89 but to aid transition (since select-compiler.sh needs to pick one of them) I've left 1.82 in there for removal later.

@richardlau

Copy link
Copy Markdown
Member Author

Also FTR we have available cargo/rustc

  • 1.82 (what we have been using)
  • 1.83
  • 1.84
  • 1.85
  • 1.89 (this PR)
  • 1.91

#4265 (comment) said we need at least 1.86, #4265 itself asked to go to Rust 1.88, so I've gone for 1.89 as the nearest match.

@richardlau richardlau merged commit d778f90 into nodejs:main Jul 3, 2026
2 checks passed
@richardlau

richardlau commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

FTR I kicked off a v26.x-staging (I'm prepping for the next release) build: https://ci.nodejs.org/job/node-test-commit/89163/

+ make run-ci -j 4 V=1
python3 ./configure --verbose 
19:59:12 Node.js configure: Found Python 3.12.3...
19:59:12 Detected clang C++ compiler (CXX=ccache clang++-19) version: 19.1.1
19:59:12 Detected clang C compiler (CC=ccache clang-19) version: 19.1.1
19:59:12 Detected cargo (CARGO=cargo-1.89): 1.89.0
19:59:12 Detected rustc (RUSTC=rustc-1.89): 1.89.0
20:00:17 + make run-ci -j 4
20:00:18 python3 ./configure --verbose  --shared-openssl
20:00:20 Node.js configure: Found Python 3.12.3...
20:00:20 Detected clang C++ compiler (CXX=ccache clang++-19) version: 19.1.1
20:00:20 Detected clang C compiler (CC=ccache clang-19) version: 19.1.1
20:00:20 Detected cargo (CARGO=cargo-1.89): 1.89.0
20:00:20 Detected rustc (RUSTC=rustc-1.89): 1.89.0
20:00:00 + make run-ci -j 8
20:00:00 python3 ./configure --verbose 
20:00:00 Node.js configure: Found Python 3.12.3...
20:00:00 Detected clang C++ compiler (CXX=ccache clang++-19) version: 19.1.1
20:00:00 Detected clang C compiler (CC=ccache clang-19) version: 19.1.1
20:00:00 Detected cargo (CARGO=cargo-1.89): 1.89.0
20:00:00 Detected rustc (RUSTC=rustc-1.89): 1.89.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants