Skip to content

port test_finalizer#55

Merged
legendecas merged 2 commits into
nodejs:mainfrom
bavulapati:feat/port-test-finalizer
Jul 24, 2026
Merged

port test_finalizer#55
legendecas merged 2 commits into
nodejs:mainfrom
bavulapati:feat/port-test-finalizer

Conversation

@bavulapati

Copy link
Copy Markdown
Contributor

No description provided.

@kraenhansen

Copy link
Copy Markdown
Member

@bavulapati I suggest keeping stacked PRs in draft until their parent PRs merge 👍

@bavulapati

Copy link
Copy Markdown
Contributor Author

depends on #53

@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Jun 5, 2026
@bavulapati
bavulapati marked this pull request as ready for review June 12, 2026 15:17
@bavulapati

Copy link
Copy Markdown
Contributor Author

@legendecas PTAL

@kraenhansen

Copy link
Copy Markdown
Member

This seems blocked on a resolution on #54.

@bavulapati
bavulapati force-pushed the feat/port-test-finalizer branch 2 times, most recently from 203a389 to 0f5dd42 Compare June 26, 2026 15:59
@bavulapati
bavulapati force-pushed the feat/port-test-finalizer branch from 0f5dd42 to 9f5ef68 Compare July 14, 2026 06:47
@bavulapati
bavulapati force-pushed the feat/port-test-finalizer branch from 9f5ef68 to d2ecbf6 Compare July 14, 2026 08:04
Comment thread tests/js-native-api/test_finalizer/test.js
Comment thread tests/js-native-api/test_finalizer/test.js Outdated

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks!

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@bavulapati
bavulapati requested a review from legendecas July 24, 2026 06:48
@legendecas
legendecas merged commit b77ecdc into nodejs:main Jul 24, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Node-API Team Project Jul 24, 2026
@bavulapati
bavulapati deleted the feat/port-test-finalizer branch July 24, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants