crypto: runtime-deprecate calling digest() on HMAC more than once#63770
Open
EduardF1 wants to merge 1 commit into
Open
crypto: runtime-deprecate calling digest() on HMAC more than once#63770EduardF1 wants to merge 1 commit into
EduardF1 wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #62838
Currently, calling
hmac.digest()multiple times on a finalized HMAC instance returns an empty buffer instead of throwingERR_CRYPTO_HASH_FINALIZED(which is what standard hashes do). As noted in the issue, this inconsistency represents a security footgun.Following the documentation-only deprecation introduced in #63121, this patch formally implements the runtime deprecation warning via
emitDeprecationWarning('DEP0206').Testing
Verified correct usage of
getDeprecationWarningEmittermapping.