Skip to content

stream: preserve half-open duplexes in async iteration#64275

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:stream/preserve-half-open
Jul 6, 2026
Merged

stream: preserve half-open duplexes in async iteration#64275
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:stream/preserve-half-open

Conversation

@efekrskl

@efekrskl efekrskl commented Jul 3, 2026

Copy link
Copy Markdown
Member

Fixes #49073

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Jul 3, 2026
@efekrskl efekrskl added the net Issues and PRs related to the net subsystem. label Jul 3, 2026
@efekrskl efekrskl changed the title stream: preserve half open duplexes in async iteration when allowHalfOpen is true stream: preserve half-open duplexes in async iteration Jul 3, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2026
@nodejs-github-bot nodejs-github-bot merged commit 6adfff9 into nodejs:main Jul 6, 2026
70 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 6adfff9

richardlau pushed a commit that referenced this pull request Jul 6, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64275
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allowHalfOpen option from net has no effect due to autoDestroy = true

5 participants