Skip to content

src: zero-initialize cap_data in node_credentials.cc#64347

Open
spkapust wants to merge 1 commit into
nodejs:mainfrom
spkapust:patch-1
Open

src: zero-initialize cap_data in node_credentials.cc#64347
spkapust wants to merge 1 commit into
nodejs:mainfrom
spkapust:patch-1

Conversation

@spkapust

@spkapust spkapust commented Jul 7, 2026

Copy link
Copy Markdown

Zero-initialize the cap_data array to prevent MSan warnings
about using uninitialized memory.

Signed-off-by: Sam Kapust samkapust@google.com

zero-initialize the cap_data array to prevent MSan warnings about using uninitialized memory
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 7, 2026
@spkapust spkapust changed the title src: zero-initialize cap_data in node_credentials.cc. src: zero-initialize cap_data in node_credentials.cc Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (4ee2117) to head (71647c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64347      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.01%     
==========================================
  Files         741      741              
  Lines      240979   240980       +1     
  Branches    45401    45396       -5     
==========================================
- Hits       217449   217427      -22     
+ Misses      15112    15109       -3     
- Partials     8418     8444      +26     
Files with missing lines Coverage Δ
src/node_credentials.cc 68.43% <100.00%> (-0.25%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hybrist

hybrist commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Can you amend the commit with the fixed message? Unfortunately changing the PR title isn't sufficient to pass the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants