vfs: make lchmod update symlink mode#64350
Open
trivikr wants to merge 1 commit into
Open
Conversation
Use a non-following provider operation for lchmod so it updates the symbolic link metadata instead of changing the target file mode. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
This comment was marked as spam.
This comment was marked as spam.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64350 +/- ##
==========================================
+ Coverage 90.23% 90.25% +0.01%
==========================================
Files 741 741
Lines 240979 240997 +18
Branches 45395 45401 +6
==========================================
+ Hits 217450 217505 +55
+ Misses 15112 15070 -42
- Partials 8417 8422 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64349
Fixes
fs.promises.lchmod()on mounted VFS paths so it updates the symboliclink's own mode instead of following the link and changing the target file mode.
This adds a non-following
lchmodSync()provider operation for the memory andreal filesystem providers, and routes VFS promise
lchmod()through it.Assisted-by: openai:gpt-5.5