vfs: fix VirtualReadStream race with async iteration#64394
Open
Y1D7NG wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#64377 Signed-off-by: y1d7ng <y1d7ng@yeah.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64394 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 741 741
Lines 241207 241196 -11
Branches 45430 45436 +6
=======================================
- Hits 217698 217693 -5
+ Misses 15084 15071 -13
- Partials 8425 8432 +7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64377
VirtualReadStream opened files on the next tick without _construct, so for-await and pipeline could read before the fd was ready and fail with EBADF. Open the virtual file in _construct instead, matching fs.ReadStream.