stream: use RangeError for broadcast overflow#64420
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Reject strict-backpressure writes with a RangeError when the broadcast pending writes queue is full. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
trivikr
force-pushed
the
stream-iter-broadcast-strict-backpressure-overflow
branch
from
July 11, 2026 07:26
46a1376 to
e37419d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64420 +/- ##
==========================================
+ Coverage 90.23% 90.26% +0.02%
==========================================
Files 741 741
Lines 241342 241342
Branches 45474 45476 +2
==========================================
+ Hits 217767 217836 +69
+ Misses 15123 15069 -54
+ Partials 8452 8437 -15
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 19, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64419
Broadcast writers using the
strictbackpressure policy currently rejectwith
ERR_INVALID_STATEas aTypeErrorwhen the pending writes queueoverflows.
This change uses
ERR_INVALID_STATE.RangeError, matching the existingpush writer behavior, and adds regression coverage for the error type and code.