src: use constexpr table for GetOctalCode#64471
Open
ansh1406 wants to merge 1 commit into
Open
Conversation
Replace the runtime std::vector<std::string> cache in GetOctalCode() with a compile-time constexpr lookup table of std::string_view Signed-off-by: Ansh Swaroop <anshswaroop14@gmail.com>
eb5cd72 to
9e25225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the runtime
std::vector<std::string>cache used byGetOctalCode()with a compile-timeconstexprlookup table ofstd::string_view.Changes
GetOctalCode()now returnsstd::string_viewinstead ofconst std::string&.There are two call sites that use
GetOctalCode():src/node_snapshotable.cc: The returned value is streamed directly to anstd::ostream, so no changes were required.tools/js2c.cc: Updated the implementation to usestd::string_view::data()instead ofstd::string::c_str().Verification