build: run perfetto build and test on GHA#64721
Open
legendecas wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
added
dont-land-on-v22.x
avivkeller
reviewed
Jul 24, 2026
Comment on lines
+44
to
+48
| path: node | ||
| - name: Install Clang ${{ env.CLANG_VERSION }} | ||
| uses: ./node/.github/actions/install-clang | ||
| with: | ||
| clang-version: ${{ env.CLANG_VERSION }} |
Member
There was a problem hiding this comment.
Suggested change
| path: node | |
| - name: Install Clang ${{ env.CLANG_VERSION }} | |
| uses: ./node/.github/actions/install-clang | |
| with: | |
| clang-version: ${{ env.CLANG_VERSION }} | |
| - name: Install Clang ${{ env.CLANG_VERSION }} | |
| uses: .github/actions/install-clang | |
| with: | |
| clang-version: ${{ env.CLANG_VERSION }} |
nit: use the CWD
Member
Author
There was a problem hiding this comment.
I replicated this from https://github.com/nodejs/node/blob/main/.github/workflows/test-linux-quic.yml. Maybe it was replicated from https://github.com/nodejs/node/blob/main/.github/workflows/test-linux.yml
avivkeller
approved these changes
Jul 24, 2026
avivkeller
left a comment
avivkeller
left a comment
Member
There was a problem hiding this comment.
LGTM, we should probably update the other workflows to use the CWD, IMO it's cleaner
Member
|
Could we enable this for the existing Linux workflow rather than adding an additional run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the
src/libchanges (like emitting trace events) are compatible with perfetto, and compatible with V8 compiled with perfetto.Refs: #64565
Fixes: nodejs/diagnostics#654