vfs: speed up recursive readdir test setup - #64813
Open
trivikr wants to merge 1 commit into
Open
Conversation
Create the deep directory tree with one recursive mkdirSync() call. This avoids repeatedly resolving increasingly long paths and prevents timeouts on slower CI hosts. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
nodejs-github-bot
added
needs-ci
Member
Author
|
Stress test can't be run on |
trivikr
marked this pull request as ready for review
July 29, 2026 03:38
trivikr
added
flaky-test
avivkeller
approved these changes
Jul 29, 2026
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64813 +/- ##
==========================================
- Coverage 90.15% 90.13% -0.02%
==========================================
Files 746 746
Lines 242660 242660
Branches 45716 45721 +5
==========================================
- Hits 218763 218724 -39
- Misses 15399 15438 +39
Partials 8498 8498 🚀 New features to boost your workflow:
|
pimterry
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-vfs-readdir-symlink-recursive%22
The deep-tree test created 1,000 directories individually using
increasingly long paths. Repeatedly resolving those paths made the test
slow enough to reach the timeout on Windows CI under load.
Construct the final path first and create the directory tree with one
recursive
mkdirSync()call. This preserves the depth and recursivereaddir coverage while avoiding the expensive setup.
Locally, on macOS, the targeted test runtime decreased from approximately
10 seconds to less than one second.
Assisted-by: codex:gpt-5.6-sol