Update libuv#321
Conversation
aduh95
left a comment
There was a problem hiding this comment.
This should 3 or 4 PRs, it's very hard to review as is. Can you please split that?
|
@aduh95 cleaned up, this now only represents the |
There was a problem hiding this comment.
Shouldn't this land separately? It doesn't seem related with the libuv update
There was a problem hiding this comment.
No, this is required for the newer libuv to build on CI
There was a problem hiding this comment.
Yes, libuv switched to using getifaddrs() that is only available on android-24 and up:
libuv/libuv@c8cbdbd
For reference, here's the failed Github Action without this change:
https://github.com/vshymanskyy/uvwasi/actions/runs/28289880098/job/83819965569
There was a problem hiding this comment.
Shouldn't this land separately? It doesn't seem related with the libuv update
There was a problem hiding this comment.
No, this is required for the newer libuv to build on CI
There was a problem hiding this comment.
Yes, the fuzzer build does not use CMake, and the patch to the static lib was hardcoded in the build.sh.
The path of the libuv.a changed, and without this fix the final binary won't link, see:
https://github.com/nodejs/uvwasi/actions/runs/28291462616/job/83824055824
|
@aduh95 all these changes are relevant, otherwise the CI checks will fail. |
The change fixes this issue: