Add option to skip building shared library#322
Merged
Conversation
Contributor
Author
|
@aduh95 this is the second part of my changes. |
aduh95
approved these changes
Jul 3, 2026
Contributor
|
I might have merged too soon, I don't seem to be able to build when I pass |
Contributor
Author
|
Oh, weird. Will recheck tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
UVWASI_BUILD_SHAREDoption, similar to that of libuv (LIBUV_BUILD_SHARED).I needed to disable the shared library build for some target platforms of Wasm3, otherwise the build fails.