Skip to content

Support callback URIs in application updates#476

Merged
AaronDDM merged 2 commits into
mainfrom
fix-application-callback-uris
Jun 12, 2026
Merged

Support callback URIs in application updates#476
AaronDDM merged 2 commits into
mainfrom
fix-application-callback-uris

Conversation

@AaronDDM

@AaronDDM AaronDDM commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Context

Follow-up to the review feedback on nylas-java#327. PATCH /v3/applications accepts callback_uris, and callers need to include an existing callback URI id when preserving or updating entries. The Python SDK typed request model did not expose that shape.

Summary

  • Add UpdateApplicationRedirectUriRequest with optional id, platform, and settings.
  • Add callback_uris to UpdateApplicationRequest and remove stale docs saying callback URIs are ignored.
  • Cover forwarding a callback_uris entry with an existing id in the application update test.
  • Update the Unreleased changelog for application callback URI preservation and invalid_also workspace auto-group support.

Testing

  • .venv/bin/black --check nylas/models/application_details.py nylas/resources/applications.py tests/resources/test_applications.py
  • .venv/bin/python -m pytest tests/resources/test_applications.py -q
  • GitHub Actions: passing

@qasim-nylas qasim-nylas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AaronDDM AaronDDM merged commit 00f3a6d into main Jun 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants