Skip to content

fix(app-shell): make AI-build "开始搭建" send a gate-matching approval#2023

Merged
xuyushun441-sys merged 1 commit into
mainfrom
claude/vigilant-volhard-6c9148
Jun 27, 2026
Merged

fix(app-shell): make AI-build "开始搭建" send a gate-matching approval#2023
xuyushun441-sys merged 1 commit into
mainfrom
claude/vigilant-volhard-6c9148

Conversation

@xuyushun441-sys

Copy link
Copy Markdown
Contributor

Problem

In the AI build "proposed plan" card (shown after the agent calls propose_blueprint), the 开始搭建 button was inert — clicking it did nothing: no build started. Typing a "确认…" reply in the chat worked, which was the tell.

Root cause

The button does send a chat message (onClick → handlePlanApprove → onSendMessage), but in Chinese it sent 就按这个方案搭建吧。, which the cloud confirm gate's APPROVAL_RE (service-ai-studio/confirm-gate.ts) does not recognize as approval — the gate anchors Chinese approval on 确认 / 直接搭建. So the agent re-proposed instead of building, and the button looked dead. The English messages already matched (build it as proposed / build it with your best); only the Chinese ones were stale relative to the (now broadened, cloud #620) gate.

Fix

Align both zh approve messages with the gate (确认-anchored), in the two hosts that wire them:

before after
planApproveMessage 就按这个方案搭建吧。 确认,开始搭建。
planApproveDefaultsMessage 就按你的合理假设直接搭建,… 确认搭建,未决问题按你的合理假设和默认处理。
  • packages/i18n/src/locales/zh.ts (used by AiChatPage)
  • packages/app-shell/src/layout/ConsoleFloatingChatbot.tsx (inline zh locale)

Plus an i18n test pinning both messages to the gate's 确认 anchor so a future reword can't silently re-break the button. Guard comments at both sites document the cross-repo coupling.

Verification

  • Unit: @object-ui/i18n (new strings + gate-anchor guard) and @object-ui/plugin-chatbot (ChatbotEnhanced button→onSendMessage wiring) green.
  • Cross-repo contract: ran the real cloud userApprovedThisTurn against the real objectui strings — new zh messages → approved; old zh → rejected (reproduces the bug); plain build requests stay rejected (gate stays narrow).
  • Live e2e on run-stack.sh --with-ui --seed: clicking 开始搭建 in the browser sent 确认,开始搭建。 (DB-confirmed) → agent ran apply_blueprint → created a real app + objects + views. Button no longer inert.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

🤖 Generated with Claude Code

The proposed-plan card's confirm button ("开始搭建") sent the Chinese
message "就按这个方案搭建吧。", which the cloud confirm gate's APPROVAL_RE
(service-ai-studio confirm-gate.ts) does NOT recognize as approval — it
anchors Chinese approval on 确认 / 直接搭建. So clicking sent a message the
agent re-proposed on instead of building, and the button looked inert
(typing a "确认…" reply worked, which is the tell).

Align both zh approve messages with the gate (确认-anchored):
  planApproveMessage         "就按这个方案搭建吧。"            → "确认,开始搭建。"
  planApproveDefaultsMessage "就按你的合理假设直接搭建,…"      → "确认搭建,未决问题按你的合理假设和默认处理。"

across the two hosts that wire them (i18n zh locale used by AiChatPage,
and ConsoleFloatingChatbot's inline zh locale). English already matched
("build it as proposed" / "build it with your best"). Adds an i18n test
that pins both messages to the gate's 确认 anchor so a future reword can't
silently re-break the button.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jun 27, 2026 10:04am

Request Review

@github-actions github-actions Bot added the tests label Jun 27, 2026
@xuyushun441-sys xuyushun441-sys merged commit 433358a into main Jun 27, 2026
10 checks passed
@xuyushun441-sys xuyushun441-sys deleted the claude/vigilant-volhard-6c9148 branch June 27, 2026 10:04
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 59.0 KB 350 KB
Entry file index-3qNf9emW.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 6.87KB 2.47KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.16KB 3.44KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 9.55KB 3.36KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 24.74KB 6.00KB
auth (createAuthenticatedFetch.js) 3.33KB 1.32KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.01KB 0.79KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 420.60KB 89.48KB
core (index.js) 1.52KB 0.55KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 99.69KB 24.89KB
fields (index.js) 164.60KB 39.84KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.30KB 10.04KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.98KB 12.65KB
plugin-charts (index.js) 45.46KB 12.78KB
plugin-chatbot (index.js) 159.77KB 38.54KB
plugin-dashboard (index.js) 107.36KB 26.65KB
plugin-designer (index.js) 213.42KB 42.94KB
plugin-detail (index.js) 197.48KB 47.68KB
plugin-editor (index.js) 2.38KB 1.06KB
plugin-form (index.js) 93.23KB 22.71KB
plugin-gantt (index.js) 136.68KB 33.88KB
plugin-grid (index.js) 120.86KB 32.74KB
plugin-kanban (index.js) 48.82KB 13.13KB
plugin-list (index.js) 94.53KB 22.32KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 13.58KB 4.64KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.21KB 2.76KB
plugin-view (index.js) 84.45KB 20.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants