feat(studio): remove the "Local / Custom" stopgap scope from the package selector (ADR-0070 D5)#2025
Merged
Merged
Conversation
…age selector (ADR-0070 D5)
Pre-launch cleanup of the final ADR-0070 D5 tail. The package-scope selector no
longer offers a synthetic "Local / Custom (this env)" entry — the
`package_id = null` / `sys_metadata` orphan bucket introduced as a stopgap in
objectui#1946.
ADR-0070 makes every runtime-authored item live in a writable base: the kernel
rejects orphan creates (`writable_package_required`, framework#2285) and legacy
orphans are adopted into a base ("Adopt loose items", framework#2301 /
objectui#1983). With no authoring path producing orphans, the bucket has no
reason to exist; since the system is pre-launch there are no environments to
migrate first.
- package-scope.ts: `buildPackageScopeOptions` returns only writable bases;
removed `LOCAL_PACKAGE_ID`, `isLocalScope`, `writableBaseOptions` and the
now-unused i18n import.
- ContextSelectors.tsx: removed the inline `LOCAL_SCOPE_ID` sentinel,
`localScopeLabel()`, and the appended Local option.
- ResourceListPage.tsx / StudioHomePage.tsx: create-flow and scope filters
simplify (active scope is always a real base; the dead `=== LOCAL` branches
are gone).
- i18n.ts: dropped the now-unused `engine.package.local` strings (en + zh).
- package-scope.test.ts: rewritten for the writable-bases-only contract.
Read-side `sys_metadata` provenance handling (row classification, editor
artifact detection) is unchanged — the kernel keeps `null` as a legacy read tag.
typecheck clean; app-shell suite 931 passed. Closes the D5 tail of #2278.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the final ADR-0070 D5 tail (tracked as objectstack-ai/framework#2359): the synthetic "Local / Custom (this env)" entry in the Studio package-scope selector — the
package_id = null/sys_metadataorphan bucket introduced as a stopgap in #1946.Why now
The system is pre-launch, so the "migrate environments to orphan-free first" precondition that gated this removal doesn't apply. The package-first contract that makes the bucket unnecessary is already shipped:
writable_package_required(feat(objectql): package-first authoring — reject runtime creates into read-only packages (ADR-0070 D1/D2) framework#2285)reassignOrphanedMetadata/ "Adopt loose items" (feat(objectql): adopt orphaned metadata into a base — ADR-0070 D5 migration framework#2301, feat(studio): package lifecycle UI — Duplicate / Adopt loose items / structure-only delete (ADR-0070 D4/D5/D6) #1983)Changes
package-scope.ts—buildPackageScopeOptionsreturns only writable bases; removedLOCAL_PACKAGE_ID,isLocalScope,writableBaseOptions, unused i18n import.ContextSelectors.tsx— removed inlineLOCAL_SCOPE_ID,localScopeLabel(), appended Local option.ResourceListPage.tsx/StudioHomePage.tsx— create-flow + scope filters simplified; dead=== LOCAL_PACKAGE_IDbranches gone.i18n.ts— dropped unusedengine.package.local(en + zh); keptengine.package.writableRequired.package-scope.test.ts— rewritten for the writable-bases-only contract.Kept on purpose
Read-side
sys_metadataprovenance handling (row classification, editor artifact detection) is unchanged — kernel keepsnullas a legacy read tag (ADR-0070 D5).Verification
pnpm type-check— 0 errors; app-shell suite — 931 passed;package-scope.test.ts— 3 passed.static-componentserror inContextSelectors.tsxis already onmain, unrelated).Closes the D5 tail of objectstack-ai/framework#2278 / objectstack-ai/framework#2359.
🤖 Generated with Claude Code