oss_17_jaeger_debug_and_parentbased_trace_state#33
Open
ocelotl wants to merge 2 commits into
Open
Conversation
Jaeger propagator inject no longer ORs in the DEBUG (forced-keep) flag for a normally-sampled span; it now propagates only the SAMPLED flag, avoiding forcing downstream Jaeger components into a forced-keep decision. ParentBased.should_sample now forwards the incoming trace_state to its delegate sampler, and the SDK Tracer now passes the parent span context's trace_state into should_sample, so the documented trace_state parameter is actually delivered to custom delegate samplers.
Owner
Author
|
🔒 Internal (dash0) — not for upstream.
|
Owner
Author
|
📣 Public-facing draft — to be used for the upstream PR in Title: Fix Jaeger inject debug flag and ParentBased What
Why
Spec
Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Jaeger inject now propagates only the SAMPLED bit (no forced DEBUG); ParentBased forwards trace_state to its delegate and the SDK passes the parent trace_state into should_sample (Linear OSS-17, findings P4/T4).
Validation: scope contained to propagator-jaeger + opentelemetry-sdk + changelog; jaeger suite 18 passed, sdk sampling+trace 124 passed. Note: one pre-existing test that asserted the old forced-DEBUG behavior was replaced.
Linear issue: https://linear.app/dash0/issue/OSS-17/p4-t4-jaeger-forces-debug-bit-on-all-sampled-spans-parentbased-drops