oss_11_m3_per_view_cardinality_limit#49
Conversation
|
🔒 Internal (dash0) — not for upstream.
|
|
📣 Public-facing draft — to be used for the upstream PR in Title: Add per-View cardinality-limit override WhatAdds an optional WhyCompletes the cardinality-limit configuration surface described by the metrics spec. Previously the limit could be set only globally (base default) or per- PrecedenceView override > per-reader default > base default (2000). An unset View override falls through to the reader default and then the base default, so existing behavior is unchanged when the new parameter is not used. Precedence is resolved in one place ( Spec
Builds onThe base default and per-reader default cardinality-limit changes. TestsNew unit tests: a View with a small limit overflows at that limit; overrides a larger reader default; overrides an unset reader; unset View falls through to reader then base default. Full metrics suite passes (315), including base and per-reader cardinality tests. |
b2a00b4 to
e579430
Compare
b1eed52 to
52efb81
Compare
Add an optional aggregation_cardinality_limit parameter to the View class that overrides both the per-MetricReader default and the base default cardinality limit for the metric streams matched by that view. Precedence (finest wins): View override > per-reader default > base default (2000). The value is threaded into the _ViewInstrumentMatch produced by the view, so a view-configured limit governs overflow for its matched streams. Builds on the base default and per-reader default cardinality limits.
52efb81 to
7784ba2
Compare
Closes #48
Per-View cardinality-limit override (Linear OSS-11, finding M3), the finest layer. Optional
View(aggregation_cardinality_limit=...); precedence View > per-reader default (M2) > base default 2000 (M1), resolved centrally in _ViewInstrumentMatch.Stacked on
oss_11_m2_per_reader_cardinality_limit(PR #44) → its base. Retarget once M1/M2 merge. Full M1→M2→M3 chain: PR #17 ← #44 ← this.Validation: M3 delta scope contained to opentelemetry-sdk + changelog; full metrics suite 315 passed (M1/M2 tests intact).
Linear issue: https://linear.app/dash0/issue/OSS-11/m1-m3-metric-cardinality-limits-base-per-reader-per-view