Skip to content

[BIO-8820] fix: fix flaky biometric token tests in CI #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvacca-onfido merged 1 commit into from
Jul 9, 2026
Merged

[BIO-8820] fix: fix flaky biometric token tests in CI #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions tests/test_biometric_tokens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import json
from time import sleep
from uuid import uuid4

import pytest
Expand All @@ -12,7 +11,7 @@
BiometricTokenUpdater,
WorkflowRunBuilder,
)
from tests.conftest import create_applicant, upload_live_photo
from tests.conftest import create_applicant, repeat_request_until_http_code_changes, upload_live_photo


@pytest.fixture(scope="function")
Expand Down Expand Up @@ -75,16 +74,15 @@ def create_biometric_token(

assert workflow_run.customer_user_id == biometric_customer_user_id

max_retries = 3
biometric_tokens = repeat_request_until_http_code_changes(
onfido_api.list_biometric_tokens,
[biometric_customer_user_id],
max_retries=10,
sleep_time=3,
)

# Wait for the biometric token to be created
for _ in range(max_retries + 1):
biometric_tokens = onfido_api.list_biometric_tokens(
biometric_customer_user_id
)
if biometric_tokens.biometric_tokens:
return biometric_tokens
sleep(2)
if biometric_tokens.biometric_tokens:
return biometric_tokens

pytest.fail("Biometric tokens were not created in time")

Expand Down
Loading