CI: Fix Windows MSVC pip build on VS 2026 runner#1889
Merged
Conversation
ax3l
force-pushed
the
fix-windows-ci-vs2026
branch
from
74b3ace to
35d0ac1
Compare
The "MSVC w/o MPI via pip" job failed on the windows-latest runner after
it upgraded to Visual Studio 2026 (VS 18):
Generator NMake Makefiles does not support platform specification,
but platform x64 was specified.
CMAKE_C_COMPILER not set, after EnableLanguage
`pip wheel` builds in an isolated environment that installs CMake per
pyproject.toml's build requirement. The `<4.0.0` cap pinned that CMake to
3.x, which predates the "Visual Studio 18 2026" generator (added in CMake
4.2), so CMake fell back to "NMake Makefiles" and rejected setup.py's
`-A x64`.
Drop the CMake upper bound so the isolated build uses a current CMake that
auto-detects the VS 2026 generator, matching the runner's own CMake that
the non-pip MSVC job already builds with. Also bump the job to Python 3.11.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ax3l
force-pushed
the
fix-windows-ci-vs2026
branch
from
35d0ac1 to
33b96a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-latest runner now ships Visual Studio 2026 (VS 18). In the "MSVC w/o MPI via pip" job, the pip-provided CMake (4.3.x) defaults to the "NMake Makefiles" generator, which rejects setup.py's
-A x64platform argument:CMake 4 was rejected in the installer due to an upper cap in
pyproject.toml