Python: Only export _PyInit_openpmd_api_cxx#1899
Merged
Merged
Conversation
Hide all other symbols to avoid clashes when loading transient (static) dependencies in workflows that combine ImpactX, WarpX, and openPMD-api. Relevant for pip/wheels that do static builds (i.e. Python wheels): Currently, openPMD-api and ImpactX could not be `import`-ed together because HDF5 would clash. Not a problem when installing with shared dependencies (of HDF5, openPMD, ABLASTR, etc.), i.e., from conda-forge or Spack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide all other symbols to avoid clashes when loading transient (static) dependencies in workflows that combine ImpactX, WarpX, and openPMD-api.
Relevant for pip/wheels that do static builds (i.e. Python wheels): Currently, openPMD-api and ImpactX could not be
import-ed together because HDF5 would clash.Not a problem when installing with shared dependencies (of HDF5, openPMD, ABLASTR, etc.), i.e., from conda-forge or Spack.
Used in #1898