Avoid noisy failed trace span for expected not-found SKILL.md during lazy skill probe (fixes #3889)#3892
Closed
MuhammadUsman-Khan wants to merge 1 commit into
Closed
Conversation
… by unwrapping session for the probe
MuhammadUsman-Khan
marked this pull request as draft
July 20, 2026 09:38
MuhammadUsman-Khan
marked this pull request as ready for review
July 20, 2026 09:38
Member
|
Thanks for sharing this idea. The issue was resolved by #3893 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid noisy failed trace span for expected not-found
SKILL.mdduring lazy skill probe.Fixes #3889
Root cause: LocalDirLazySkillSource.load_skill used the instrumented SandboxSession.read() to probe for SKILL.md. On first lazy load this probe raises WorkspaceReadNotFoundError (expected) and the instrumentation recorded a failed child span even though the exception is handled and the overall load succeeds.
Solution: For the existence probe only, unwrap a SandboxSession wrapper (if present) to get the underlying BaseSandboxSession and call its read() directly. This prevents the expected handled-not-found from being recorded as an error span. The change is tiny and contained to src/agents/sandbox/capabilities/skills.py.
Files changed:
Testing performed:
Limitations / follow-up: