Skip to content

fix(visualization): escape multiline DOT names#3898

Merged
seratch merged 1 commit into
openai:mainfrom
hsusul:fix/escape-multiline-visualization-names
Jul 20, 2026
Merged

fix(visualization): escape multiline DOT names#3898
seratch merged 1 commit into
openai:mainfrom
hsusul:fix/escape-multiline-visualization-names

Conversation

@hsusul

@hsusul hsusul commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This pull request fixes malformed Graphviz DOT output when agent, tool, MCP server, or handoff names contain physical line breaks.

Summary

  • Encode line breaks in visualization names using Graphviz's \n escape.
  • Normalize LF, CRLF, and lone CR without changing ordinary names or literal backslash sequences.
  • Add regression coverage for multiline node labels, identifiers, and edges.

Test plan

  • uv run pytest -s tests/test_visualization.py -k line_breaks
  • uv run pytest -s tests/test_visualization.py
  • .agents/skills/code-change-verification/scripts/run.sh
  • git diff --check upstream/main..HEAD
  • Codex /review

Issue number

N/A — newly discovered unreported bug.

Checks

  • I've added new tests, if relevant
  • I've run .agents/skills/code-change-verification/scripts/run.sh
  • I've confirmed all verification steps pass
  • If using Codex, I've run /review before submitting this PR

@seratch seratch added this to the 0.19.x milestone Jul 20, 2026
@seratch
seratch merged commit 3384027 into openai:main Jul 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants